linux-kernel - Re: [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jan 2022 18:16:21 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is
 set but never used

Thus wrote Michael Straube (straube.linux@...il.com):

> The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set
> but never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> v3: no changes
> v2: no changes

>  drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 ---
>  drivers/staging/r8188eu/include/rtl8188e_hal.h  | 1 -
>  2 files changed, 4 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index d8d6547465a7..065c2701077d 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter, u8 *PROMContent, bool Auto

>  	Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail);

> -	if (!AutoLoadFail)
> -		pHalData->bTXPowerDataReadFromEEPORM = true;
> -
>  	for (ch = 0; ch < CHANNEL_MAX_NUMBER; ch++) {
>  		hal_get_chnl_group_88e(ch, &group);

> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 8b54f52f49e2..de58c85b8bdc 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -180,7 +180,6 @@ struct hal_data_8188e {
>  	u16	EEPROMSDID;
>  	u8	EEPROMRegulatory;

> -	u8	bTXPowerDataReadFromEEPORM;
>  	u8	EEPROMThermalMeter;
>  	u8	bAPKThermalMeterIgnore;

> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@...ser.cx>