linux-kernel - Re: [PATCH] perf: fix typos of "its" and "reponse"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdIsK7BI+sG36B1m@li-24c3614c-2adc-11b2-a85c-85f334518bdb.ibm.com>
Date:   Sun, 2 Jan 2022 16:50:19 -0600
From:   "Paul A. Clarke" <pc@...ibm.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf: fix typos of "its" and "reponse"

On Sat, Dec 25, 2021 at 06:52:15PM -0800, Randy Dunlap wrote:
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.

> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",

You should probably s/till/until/, since you're already modifying those lines.
Is there a reason that "Coherent" is capitalized here?

> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",

same

PC