linux-kernel - Re: [PATCH] perf: fix typos of "its" and "reponse"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAP-5=fXHUg9jEOmGxCk3UP2mdb8oSCyg-UenL1k7MhLFAaaj5Q@mail.gmail.com>
Date:   Sun, 2 Jan 2022 17:01:53 -0800
From:   Ian Rogers <irogers@...gle.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        "zhengjun.xing@...el.com" <zhengjun.xing@...el.com>
Cc:     linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH] perf: fix typos of "its" and "reponse"

On Sat, Dec 25, 2021 at 6:52 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> Use the possessive "its" instead of the contraction of "it is" ("it's")
> where needed in user-viewable messages.
>
> Correct typos of "reponse" to "response" (reported by checkpatch).
>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>
> Cc: Mark Rutland <mark.rutland@....com>
> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: linux-perf-users@...r.kernel.org

Making this information better is valuable! The data is autogenerated
by these scripts:
https://github.com/intel/event-converter-for-linux-perf
>From data here:
https://download.01.org/perfmon/
In a way the files that are in the tree are temporary build files.
Perhaps we can have the original source and scripts within the Linux
tools tree to simplify fixes like these.

Thanks,
Ian



> ---
>  tools/perf/pmu-events/arch/x86/broadwell/uncore.json          |    6 +++---
>  tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json |    4 ++--
>  tools/perf/pmu-events/arch/x86/haswell/uncore.json            |    6 +++---
>  tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json     |    4 ++--
>  4 files changed, 10 insertions(+), 10 deletions(-)
>
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/broadwell/uncore.json
> @@ -184,8 +184,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
>      "Counter": "0,",
>      "CounterMask": "0",
>      "Invert": "0",
> @@ -275,4 +275,4 @@
>      "Invert": "0",
>      "EdgeDetect": "0"
>    }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/cascadelakex/uncore-other.json
> @@ -514,7 +514,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket.  This snoop response is only used in >= 4 socket systems.  It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> +        "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket.  This snoop response is only used in >= 4 socket systems.  It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
>          "UMask": "0x20",
>          "Unit": "CHA"
>      },
> @@ -524,7 +524,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home.  This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured.  This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> +        "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home.  This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured.  This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
>          "UMask": "0x10",
>          "Unit": "CHA"
>      },
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/haswell/uncore.json
> @@ -304,8 +304,8 @@
>      "EventCode": "0x80",
>      "UMask": "0x01",
>      "EventName": "UNC_ARB_TRK_OCCUPANCY.ALL",
> -    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> -    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from it's allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "BriefDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
> +    "PublicDescription": "Each cycle count number of all Core outgoing valid entries. Such entry is defined as valid from its allocation till first of IDI0 or DRS0 messages is sent out. Accounts for Coherent and non-coherent traffic.",
>      "Counter": "0",
>      "CounterMask": "0",
>      "Invert": "0",
> @@ -371,4 +371,4 @@
>      "Invert": "0",
>      "EdgeDetect": "0"
>    }
> -]
> \ No newline at end of file
> +]
> --- linux-next-20211224.orig/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> +++ linux-next-20211224/tools/perf/pmu-events/arch/x86/skylakex/uncore-other.json
> @@ -514,7 +514,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_FWD_WB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to it's home socket, and the cacheline was forwarded to the requestor socket.  This snoop response is only used in >= 4 socket systems.  It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to it's home socket to be written back to memory.",
> +        "PublicDescription": "Counts when a transaction with the opcode type Rsp*Fwd*WB Snoop Response was received which indicates the data was written back to its home socket, and the cacheline was forwarded to the requestor socket.  This snoop response is only used in >= 4 socket systems.  It is used when a snoop HITM's in a remote caching agent and it directly forwards data to a requestor, and simultaneously returns data to its home socket to be written back to memory.",
>          "UMask": "0x20",
>          "Unit": "CHA"
>      },
> @@ -524,7 +524,7 @@
>          "EventCode": "0x5C",
>          "EventName": "UNC_CHA_SNOOP_RESP.RSP_WBWB",
>          "PerPkg": "1",
> -        "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to it's home.  This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured.  This reponse will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
> +        "PublicDescription": "Counts when a transaction with the opcode type Rsp*WB Snoop Response was received which indicates which indicates the data was written back to its home.  This is returned when a non-RFO request hits a cacheline in the Modified state. The Cache can either downgrade the cacheline to a S (Shared) or I (Invalid) state depending on how the system has been configured.  This response will also be sent when a cache requests E (Exclusive) ownership of a cache line without receiving data, because the cache must acquire ownership.",
>          "UMask": "0x10",
>          "Unit": "CHA"
>      },