linux-kernel - Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220102234633.31709-1-miles.chen@mediatek.com>
Date:   Mon, 3 Jan 2022 07:46:32 +0800
From:   <miles.chen@...iatek.com>
To:     <matthias.bgg@...il.com>, Nathan Chancellor <nathan@...nel.org>,
        "Nick Desaulniers" <ndesaulniers@...gle.com>,
        Jie Qiu <jie.qiu@...iatek.com>,
        "Junzhi Zhao" <junzhi.zhao@...iatek.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     <airlied@...ux.ie>, <chunkuang.hu@...nel.org>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <miles.chen@...iatek.com>,
        <llvm@...ts.linux.dev>
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

> I'm still not happy with the commit subject, I think it is misleading. Clang 
> only helped to find the bug, but the we are fixing something else, that's not 
> just a clang warning. But I don't want to nit-pick too much so:
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

thanks. I think you are right.
I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the 
clang part and submit patch v4.

e.g,
"""
drm/mediatek: Fix mtk_cec_mask()

In current implementation, mtk_cec_mask() writes val into target register
and ignores the mask. After talking to our hdmi experts, mtk_cec_mask()
should read a register, clean only mask bits, and update (val | mask) bits
to the register.

Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
"""