linux-kernel - Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220107014046.30492-1-miles.chen@mediatek.com>
Date:   Fri, 7 Jan 2022 09:40:46 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <matthias.bgg@...il.com>
CC:     <airlied@...ux.ie>, <chunkuang.hu@...nel.org>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <jie.qiu@...iatek.com>,
        <junzhi.zhao@...iatek.com>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <llvm@...ts.linux.dev>,
        <p.zabel@...gutronix.de>
Subject: Re: [PATCH v3] drm/mediatek: Fix unused-but-set variable warning

Hi Matthias,

>> I'm still not happy with the commit subject, I think it is misleading. Clang 
>> only helped to find the bug, but the we are fixing something else, that's not 
>> just a clang warning. But I don't want to nit-pick too much so:
>> 
>> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> thanks. I think you are right.
> I will change the subject to "drm/mediatek: Fix mtk_cec_mask()", remove the 
> clang part and submit patch v4.

I posted patch v4 https://lore.kernel.org/linux-mediatek/20220103054706.8072-1-miles.chen@mediatek.com/
without your reviewed-by tag.

Would you mind taking a look at the patch?

Miles