[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87pmp9tcju.fsf@intel.com>
Date: Mon, 03 Jan 2022 11:04:53 +0200
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Tomasz Warniełło <tomasz.warniello@...il.com>,
Jonathan Corbet <corbet@....net>
Cc: linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: transform documentation into POD
On Mon, 03 Jan 2022, Tomasz Warniełło <tomasz.warniello@...il.com> wrote:
> On 17/12/2021 00:12, Jonathan Corbet wrote:
>>> my $kernelversion;
>>> @@ -468,7 +306,7 @@ while ($ARGV[0] =~ m/^--?(.*)/) {
>>> } elsif ($cmd eq "Werror") {
>>> $Werror = 1;
>>> } elsif (($cmd eq "h") || ($cmd eq "help")) {
>>> - usage();
>>> + pod2usage(-exitval => 0, -verbose => 2);
>>
>> Why the strange indentation here? This file is far from pretty, but
>> that makes it worse. (Other places too).
>
> Sometimes beauty requires cooperation. You can help it in your pager.
> If it's less, then try `-x 2`, `-x 4`, etc.
In kernel, tabs are 8 characters.
See Documentation/process/coding-style.rst
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
Powered by blists - more mailing lists