linux-kernel - Re: [PATCH] scripts: kernel-doc: transform documentation into POD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220103183034.77ba8a8c@fuji.fritz.box>
Date:   Mon, 3 Jan 2022 18:30:34 +0100
From:   Tomasz Warniełło <tomasz.warniello@...il.com>
To:     Jani Nikula <jani.nikula@...ux.intel.com>
Cc:     Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: transform documentation into POD

On Mon, 03 Jan 2022 11:04:53 +0200
Jani Nikula <jani.nikula@...ux.intel.com> wrote:

> On Mon, 03 Jan 2022, Tomasz Warniełło <tomasz.warniello@...il.com> wrote:
> > On 17/12/2021 00:12, Jonathan Corbet wrote:  
> >>>  my $kernelversion;
> >>> @@ -468,7 +306,7 @@ while ($ARGV[0] =~ m/^--?(.*)/) {
> >>>      } elsif ($cmd eq "Werror") {
> >>>  	$Werror = 1;
> >>>      } elsif (($cmd eq "h") || ($cmd eq "help")) {
> >>> -	usage();
> >>> +			pod2usage(-exitval => 0, -verbose => 2);  
> >> 
> >> Why the strange indentation here?  This file is far from pretty, but
> >> that makes it worse.  (Other places too).  
> >
> > Sometimes beauty requires cooperation. You can help it in your pager.
> > If it's less, then try `-x 2`, `-x 4`, etc.  
> 
> In kernel, tabs are 8 characters.
> 
> See Documentation/process/coding-style.rst
> 
> 
> BR,
> Jani.
> 
> 

I am a heretic then.

Except for the initial dogma, I understand and agree with the rationale
in coding-style.rst.

Only what if I have stared at the screen not for 20 hours, but for
40 hours? Now I want to have indentation even deeper, of 16 spaces.
And how do I get this having 8 spaces here and there instead of tabs?
The system begins to fall apart.

The misleading statement is that tabs are 8 characters long. No. They
are exactly 1 character long. And that's ASCII 9.

Cheers,
TW