linux-kernel - Re: [PATCH] staging: r8188eu: remove unneeded ret variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdL6CE3+CaU6xVvD@kroah.com>
Date:   Mon, 3 Jan 2022 14:28:40 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abdun Nihaal <abdun.nihaal@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unneeded ret variables

On Fri, Dec 31, 2021 at 10:55:27PM +0530, Abdun Nihaal wrote:
> Remove unneeded return variables in ioctl_linux.c that are initialized
> to 0 and are not assigned after. Instead, return 0 directly.

Almost all of these should not be returning a value at all, if they can
not fail and no one checks the values, right?

Please fix this up to be functions that return void, as that's the
correct thing to do here.

thanks,

greg k-h