linux-kernel - Re: [PATCH] staging: r8188eu: remove unneeded ret variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Jan 2022 23:49:16 +0530
From:   Abdun Nihaal <abdun.nihaal@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unneeded ret variables

Hello,

On Mon, Jan 03, 2022 at 02:28:40PM +0100, Greg KH wrote:
> On Fri, Dec 31, 2021 at 10:55:27PM +0530, Abdun Nihaal wrote:
> > Remove unneeded return variables in ioctl_linux.c that are initialized
> > to 0 and are not assigned after. Instead, return 0 directly.
> 
> Almost all of these should not be returning a value at all, if they can
> not fail and no one checks the values, right?

Yes. My bad. I saw that some of the functions were iw_handler functions and
had assumed that all of them were iw_handler functions.

> Please fix this up to be functions that return void, as that's the
> correct thing to do here.

Sure. I'll split it into two patches (one for iw_handler functions that
need to return int, and one for functions whose return value are not
used ) and send a v2 patchset.

Thanks,
Abdun Nihaal