linux-kernel - Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ha6gcnboz.wl-tiwai@suse.de>
Date:   Mon, 03 Jan 2022 15:19:56 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Christian Lachner <gladiac@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, kailang@...ltek.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570  Aorus Master after reboot from Windows

On Mon, 03 Jan 2022 15:05:17 +0100,
Christian Lachner wrote:
> 
> This patch addresses an issue where after rebooting from Windows into Linux
> there would be no audio output.
> 
> It turns out that the Realtek Audio driver on Windows changes some coeffs
> which are not being reset/reinitialized when rebooting the machine. As a
> result, there is no audio output until these coeffs are being reset to
> their initial state. This patch takes care of that by setting known-good
> (initial) values to the coeffs.
> 
> We initially relied upon alc1220_fixup_clevo_p950() to fix some pins in the
> connection list. However, it also sets coef 0x7 which does not need to be
> touched. Furthermore, to prevent mixing device-specific quirks I introduced
> a new alc1220_fixup_gb_x570() which is heavily based on
> alc1220_fixup_clevo_p950() but does not set coeff 0x7 and fixes the coeffs
> that are actually needed instead.
> 
> This new alc1220_fixup_gb_x570() is believed to also work for other boards,
> like the Gigabyte X570 Aorus Extreme and the newer Gigabyte Aorus X570S
> Master. However, as there is no way for me to test these I initially only
> enable this new behaviour for the mainboard I have which is the Gigabyte
> X570(non-S) Aorus Master.
> 
> I tested this patch on the 5.15 branch as well as on master and it is
> working well for me.
> 
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205275
> Signed-off-by: Christian Lachner <gladiac@...il.com>

Thanks, applied now (with Cc-to-stable and Fixes tag).


Takashi