linux-kernel - Re: [PATCH] headers/uninline: Uninline single-use function: kobject_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdRjRWHgvnqVe8UZ@kroah.com>
Date:   Tue, 4 Jan 2022 16:09:57 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     "Kirill A. Shutemov" <kirill@...temov.name>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Ard Biesheuvel <ardb@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jonathan Corbet <corbet@....net>,
        Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH] headers/uninline: Uninline single-use function:
 kobject_has_children()

On Tue, Jan 04, 2022 at 02:54:31PM +0100, Ingo Molnar wrote:
> 
> * Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> > On Tue, Jan 04, 2022 at 11:54:55AM +0100, Ingo Molnar wrote:
> > > There's one happy exception though, all the uninlining patches that 
> > > uninline a single-call function are probably fine as-is:
> > 
> > <snip>
> > 
> > >  3443e75fd1f8 headers/uninline: Uninline single-use function: kobject_has_children()
> > 
> > Let me go take this right now, no need for this to wait, it should be
> > out of kobject.h as you rightfully show there is only one user.
> 
> Sure - here you go!

I just picked it out of your git tree already :)

Along those lines, any objection to me taking at least one other one?
3f8757078d27 ("headers/prep: usb: gadget: Fix namespace collision") and
6fb993fa3832 ("headers/deps: USB: Optimize <linux/usb/ch9.h>
dependencies, remove <linux/device.h>") look like I can take now into my
USB tree with no problems.

thanks,

greg k-h