| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aa3bdf14-582c-2636-cdd4-cec2013d2b10@collabora.com>
Date: Tue, 4 Jan 2022 16:53:29 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Yong Wu <yong.wu@...iatek.com>, Joerg Roedel <joro@...tes.org>,
Rob Herring <robh+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Will Deacon <will@...nel.org>,
Robin Murphy <robin.murphy@....com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
Tomasz Figa <tfiga@...omium.org>,
linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
iommu@...ts.linux-foundation.org,
Hsin-Yi Wang <hsinyi@...omium.org>, youlin.pei@...iatek.com,
anan.sun@...iatek.com, chao.hao@...iatek.com,
yen-chang.chen@...iatek.com
Subject: Re: [PATCH v3 32/33] iommu/mediatek: Backup/restore regsiters for
multi banks
Il 23/09/21 13:58, Yong Wu ha scritto:
> Each bank has some independent registers. thus backup/restore them for
> each a bank when suspend and resume.
>
> Signed-off-by: Yong Wu <yong.wu@...iatek.com>
> ---
> drivers/iommu/mtk_iommu.c | 39 +++++++++++++++++++++++++++------------
> drivers/iommu/mtk_iommu.h | 14 +++++++++++---
> 2 files changed, 38 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
> index 3925d1d4f2cf..3cb18ed28132 100644
> --- a/drivers/iommu/mtk_iommu.c
> +++ b/drivers/iommu/mtk_iommu.c
> @@ -1114,16 +1114,23 @@ static int __maybe_unused mtk_iommu_runtime_suspend(struct device *dev)
> {
> struct mtk_iommu_data *data = dev_get_drvdata(dev);
> struct mtk_iommu_suspend_reg *reg = &data->reg;
> - void __iomem *base = data->bank[0].base;
> + void __iomem *base;
> + int i = 0;
>
> + base = data->bank[i].base;
> reg->wr_len_ctrl = readl_relaxed(base + REG_MMU_WR_LEN_CTRL);
> reg->misc_ctrl = readl_relaxed(base + REG_MMU_MISC_CTRL);
> reg->dcm_dis = readl_relaxed(base + REG_MMU_DCM_DIS);
> reg->ctrl_reg = readl_relaxed(base + REG_MMU_CTRL_REG);
> - reg->int_control0 = readl_relaxed(base + REG_MMU_INT_CONTROL0);
> - reg->int_main_control = readl_relaxed(base + REG_MMU_INT_MAIN_CONTROL);
> - reg->ivrp_paddr = readl_relaxed(base + REG_MMU_IVRP_PADDR);
> reg->vld_pa_rng = readl_relaxed(base + REG_MMU_VLD_PA_RNG);
> + do {
> + if (!data->plat_data->bank_enable[i])
> + continue;
> + base = data->bank[i].base;
> + reg->int_control[i] = readl_relaxed(base + REG_MMU_INT_CONTROL0);
> + reg->int_main_control[i] = readl_relaxed(base + REG_MMU_INT_MAIN_CONTROL);
> + reg->ivrp_paddr[i] = readl_relaxed(base + REG_MMU_IVRP_PADDR);
> + } while (++i < data->plat_data->bank_nr);
> clk_disable_unprepare(data->bclk);
> return 0;
> }
> @@ -1132,9 +1139,9 @@ static int __maybe_unused mtk_iommu_runtime_resume(struct device *dev)
> {
> struct mtk_iommu_data *data = dev_get_drvdata(dev);
> struct mtk_iommu_suspend_reg *reg = &data->reg;
> - struct mtk_iommu_domain *m4u_dom = data->bank[0].m4u_dom;
> - void __iomem *base = data->bank[0].base;
> - int ret;
> + struct mtk_iommu_domain *m4u_dom;
> + void __iomem *base;
> + int ret, i = 0;
>
> ret = clk_prepare_enable(data->bclk);
> if (ret) {
> @@ -1157,18 +1164,26 @@ static int __maybe_unused mtk_iommu_runtime_resume(struct device *dev)
> * Uppon first resume, only enable the clk and return, since the values of the
> * registers are not yet set.
> */
> - if (!m4u_dom)
> + if (!reg->wr_len_ctrl)
> return 0;
>
> + base = data->bank[i].base;
> writel_relaxed(reg->wr_len_ctrl, base + REG_MMU_WR_LEN_CTRL);
> writel_relaxed(reg->misc_ctrl, base + REG_MMU_MISC_CTRL);
> writel_relaxed(reg->dcm_dis, base + REG_MMU_DCM_DIS);
> writel_relaxed(reg->ctrl_reg, base + REG_MMU_CTRL_REG);
> - writel_relaxed(reg->int_control0, base + REG_MMU_INT_CONTROL0);
> - writel_relaxed(reg->int_main_control, base + REG_MMU_INT_MAIN_CONTROL);
> - writel_relaxed(reg->ivrp_paddr, base + REG_MMU_IVRP_PADDR);
> writel_relaxed(reg->vld_pa_rng, base + REG_MMU_VLD_PA_RNG);
> - writel(m4u_dom->cfg.arm_v7s_cfg.ttbr & MMU_PT_ADDR_MASK, base + REG_MMU_PT_BASE_ADDR);
> + do {
> + m4u_dom = data->bank[i].m4u_dom;
> + if (!data->plat_data->bank_enable[i] || !m4u_dom)
> + continue;
> + base = data->bank[i].base;
> + writel_relaxed(reg->int_control[i], base + REG_MMU_INT_CONTROL0);
> + writel_relaxed(reg->int_main_control[i], base + REG_MMU_INT_MAIN_CONTROL);
> + writel_relaxed(reg->ivrp_paddr[i], base + REG_MMU_IVRP_PADDR);
> + writel(m4u_dom->cfg.arm_v7s_cfg.ttbr & MMU_PT_ADDR_MASK,
> + base + REG_MMU_PT_BASE_ADDR);
> + } while (++i < data->plat_data->bank_nr);
> return 0;
> }
>
> diff --git a/drivers/iommu/mtk_iommu.h b/drivers/iommu/mtk_iommu.h
> index cf4b3d10cf2c..e781ad583131 100644
> --- a/drivers/iommu/mtk_iommu.h
> +++ b/drivers/iommu/mtk_iommu.h
> @@ -33,11 +33,19 @@ struct mtk_iommu_suspend_reg {
> };
> u32 dcm_dis;
> u32 ctrl_reg;
> - u32 int_control0;
> - u32 int_main_control;
> - u32 ivrp_paddr;
> u32 vld_pa_rng;
> u32 wr_len_ctrl;
> + union {
> + struct { /* only for gen1 */
> + u32 int_control0;
> + };
> +
> + struct { /* only for gen2 that support multi-banks */
> + u32 int_control[MTK_IOMMU_BANK_MAX];
> + u32 int_main_control[MTK_IOMMU_BANK_MAX];
> + u32 ivrp_paddr[MTK_IOMMU_BANK_MAX];
> + };
> + };
There's no need for yet another union... just update mtk_iommu_v1.c to use
int_control[0] instead of int_control0.
> };
>
> enum mtk_iommu_plat {
>
Powered by blists - more mailing lists