linux-kernel - Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f8ef75a-9743-b89e-3d6b-ca4907db2de0@gmail.com>
Date:   Tue, 4 Jan 2022 10:12:54 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Al Cooper <alcooperx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Prabhakar <prabhakar.csengg@...il.com>,
        linux-serial@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of
 dma_alloc_coherent() failure

On 1/4/22 9:50 AM, Lad Prabhakar wrote:
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
> 
> Fixes: c195438f1e84 ("serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()")
> Reported-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Acked-by: Florian Fainelli <f.fainelli@...il.com>

The fixes tag may be a bit superfluous since this is just an error path,
but it is correct nonetheless.
-- 
Florian