linux-kernel - Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdp1f84MUp01OYHb6HQ8G4zu8bXOQPbkC_xgHVdsYHnNw@mail.gmail.com>
Date:   Wed, 5 Jan 2022 11:48:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Al Cooper <alcooperx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Prabhakar <prabhakar.csengg@...il.com>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@...adcom.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250_bcm7271: Fix return error code in case of
 dma_alloc_coherent() failure

On Tue, Jan 4, 2022 at 7:50 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@...renesas.com> wrote:
>
> In case of dma_alloc_coherent() failure return -ENOMEM instead of
> returning -EINVAL.
>
> Fixes: c195438f1e84 ("serial: 8250_bcm7271: Propagate error codes from brcmuart_probe()")

It doesn't fix any issue that needs to be backported.
After dropping that tag,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Reported-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> ---
> Hi All,
>
> This patch applies to -next.

The rule of thumb is to test it against the subsystem thru which you
are routing your patch, in this case you need to use tty-next.

>
> Cheers,
> Prabhakar
> ---
>  drivers/tty/serial/8250/8250_bcm7271.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index cc60a7874e8b..9b878d023dac 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -1075,7 +1075,7 @@ static int brcmuart_probe(struct platform_device *pdev)
>                                                    priv->rx_size,
>                                                    &priv->rx_addr, GFP_KERNEL);
>                 if (!priv->rx_bufs) {
> -                       ret = -EINVAL;
> +                       ret = -ENOMEM;
>                         goto err;
>                 }
>                 priv->tx_size = UART_XMIT_SIZE;
> @@ -1083,7 +1083,7 @@ static int brcmuart_probe(struct platform_device *pdev)
>                                                   priv->tx_size,
>                                                   &priv->tx_addr, GFP_KERNEL);
>                 if (!priv->tx_buf) {
> -                       ret = -EINVAL;
> +                       ret = -ENOMEM;
>                         goto err;
>                 }
>         }
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko