linux-kernel - Re: linux-next: manual merge of the dmaengine tree with the dmaengine-fixes tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdVGmkzgUmvPDmlE@matsya>
Date:   Wed, 5 Jan 2022 12:49:54 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Dave Jiang <dave.jiang@...el.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: linux-next: manual merge of the dmaengine tree with the
 dmaengine-fixes tree

On 05-01-22, 10:04, Stephen Rothwell wrote:
> Hi Dave,
> 
> On Tue, 4 Jan 2022 14:41:00 -0700 Dave Jiang <dave.jiang@...el.com> wrote:
> >
> > >>   +       */
> > >>   +      list_for_each_entry_safe(d, t, &flist, list) {
> > >>   +              list_del_init(&d->list);
> > >> -               complete_desc(d, IDXD_COMPLETE_NORMAL);
> > >> ++              idxd_dma_complete_txd(d, IDXD_COMPLETE_NORMAL, false);  
> > > Is "false" correct here?  
> > 
> > Hi Geert, took a closer look today. I believe it should be 'true'
> > here since this is a normal completion that needs to release the
> > descriptors. Sorry about the previous incorrect response.
> 
> I have updated my resolution from today.  Thanks for the feedback.

I have merged fixes into next as well, so this should not be required
tomorrow.

Dave pls test..

-- 
~Vinod