linux-kernel - Re: [PATCH] clk: socfpga: remove redundant assignment after a mask operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220106003318.E28E7C36AE9@smtp.kernel.org>
Date:   Wed, 05 Jan 2022 16:33:17 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>,
        Dinh Nguyen <dinguyen@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-clk@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: socfpga: remove redundant assignment after a mask operation

Quoting Colin Ian King (2021-12-30 07:03:21)
> The assignment operation after a & mask operation is redundant, the
> variables being assigned are not used afterwards. Replace the &=
> operator with just & operator.
> 
> Cleans up two clang-scan warnings:
> drivers/clk/socfpga/clk-gate.c:37:10: warning: Although the value stored
> to 'l4_src' is used in the enclosing expression, the value is never
> actually read from 'l4_src' [deadcode.DeadStores]
>                 return l4_src &= 0x1;
>                        ^         ~~~
> drivers/clk/socfpga/clk-gate.c:46:10: warning: Although the value stored
> to 'perpll_src' is used in the enclosing expression, the value is never
> actually read from 'perpll_src' [deadcode.DeadStores]
>                 return perpll_src &= 0x3;
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---

Applied to clk-next