linux-kernel - Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220107065210.7utcwjenvcspydyk@nlap2>
Date:   Fri, 7 Jan 2022 12:22:10 +0530
From:   Abdun Nihaal <abdun.nihaal@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void

Hello Greg,

On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote:
> On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote:
> > Some functions in ioctl_linux.c always returns 0 and their return values
> > are never used. Change return type of such functions to void.
> > 
> > While at it, align function arguments with open parenthesis to fix
> > checkpatch checks.
> > 
> > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>
> 
> Are you sure that checkpatch allowed this change?

Yes, I ran checkpatch on both the patches and found no errors, warnings
or checks. Is there something that needs to be fixed?

Regards,
Abdun Nihaal