linux-kernel - Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 11:58:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Abdun Nihaal <abdun.nihaal@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, straube.linux@...il.com, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] staging: r8188eu: change functions to return void

On Fri, Jan 07, 2022 at 12:22:10PM +0530, Abdun Nihaal wrote:
> Hello Greg,
> 
> On Thu, Jan 06, 2022 at 06:58:50PM +0100, Greg KH wrote:
> > On Thu, Jan 06, 2022 at 11:11:52PM +0530, Abdun Nihaal wrote:
> > > Some functions in ioctl_linux.c always returns 0 and their return values
> > > are never used. Change return type of such functions to void.
> > > 
> > > While at it, align function arguments with open parenthesis to fix
> > > checkpatch checks.
> > > 
> > > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Signed-off-by: Abdun Nihaal <abdun.nihaal@...il.com>
> > 
> > Are you sure that checkpatch allowed this change?
> 
> Yes, I ran checkpatch on both the patches and found no errors, warnings
> or checks. Is there something that needs to be fixed?

You're not allowed to end a void function with a return statement.

Checkpatch will only detect these if you run it again with the -f
option.

regards,
dan carpenter