linux-kernel - Re: [PATCH] clk: bm1880: remove kfrees on static allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220107014652.E7FB7C36AE0@smtp.kernel.org>
Date:   Thu, 06 Jan 2022 17:46:51 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Mmturquette@...libre.com, conor.dooley@...rochip.com,
        linux-clk@...r.kernel.org, mani@...nel.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        daire.mcnamara@...rochip.com, mail@...chuod.ie,
        Conor Dooley <conor.dooley@...rochip.com>
Subject: Re: [PATCH] clk: bm1880: remove kfrees on static allocations

Quoting conor.dooley@...rochip.com (2021-12-23 07:42:44)
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> bm1880_clk_unregister_pll & bm1880_clk_unregister_div both try to
> free statically allocated variables, so remove those kfrees.
> 
> For example, if we take L703 kfree(div_hw):
> - div_hw is a bm1880_div_hw_clock pointer
> - in bm1880_clk_register_plls this is pointed to an element of arg1:
>   struct bm1880_div_hw_clock *clks
> - in the probe, where bm1880_clk_register_plls is called arg1 is
>   bm1880_div_clks, defined on L371:
>   static struct bm1880_div_hw_clock bm1880_div_clks[]
> 
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---

Applied to clk-next