linux-kernel - Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Jan 2022 22:58:40 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Gabriel L. Somlo" <gsomlo@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Kamil Rakoczy <krakoczy@...micro.com>,
        mdudek@...ernships.antmicro.com,
        Paul Mackerras <paulus@...abs.org>,
        Joel Stanley <joel@....id.au>,
        Stafford Horne <shorne@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        david.abdurachmanov@...ive.com,
        Florent Kermarrec <florent@...oy-digital.fr>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Fri, Jan 7, 2022 at 10:50 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
> On Fri, Jan 7, 2022 at 7:08 PM Gabriel L. Somlo <gsomlo@...il.com> wrote:
> > On Fri, Jan 07, 2022 at 12:06:16PM -0500, Gabriel Somlo wrote:

...

> > Any more ordering or devm vs. non-devm mixing violations here? If so,
> > can you please link me to an example or some docs where I ould figure
> > out what it is I'm still doing wrong?
>
> Device managed resources are attached to the instance of the device
> object and removed in the order they have been attached to, but with
> the caveat that they have no clue about non-managed calls in between.
> Now you may figure out what happens. Ex.:
>
> probe()
>   A
>   devm_B
>   C
>   devm_D
>
> remove()
>   un_C
>   un_A
>
> WRONG!

For the sake of comprehensivity of the examples the right one(s) depicted below:

->probe()

1)
  devm_A
  devm_B
  C
  D

2)
  A
  B
  C
  D

3)
  devm_A
  devm_B
  devm_C
  devm_D

Hint:
`git log --no-merges --grep devm_add_action_or_reset`


-- 
With Best Regards,
Andy Shevchenko