linux-kernel - Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YditLMRpj0BaG9O0@errol.ini.cmu.edu>
Date:   Fri, 7 Jan 2022 16:14:20 -0500
From:   "Gabriel L. Somlo" <gsomlo@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Kamil Rakoczy <krakoczy@...micro.com>,
        mdudek@...ernships.antmicro.com,
        Paul Mackerras <paulus@...abs.org>,
        Joel Stanley <joel@....id.au>,
        Stafford Horne <shorne@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        david.abdurachmanov@...ive.com,
        Florent Kermarrec <florent@...oy-digital.fr>,
        Randy Dunlap <rdunlap@...radead.org>
Subject: Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Fri, Jan 07, 2022 at 10:54:12PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 7, 2022 at 7:06 PM Gabriel Somlo <gsomlo@...il.com> wrote:
> >
> > LiteX (https://github.com/enjoy-digital/litex) is a SoC framework
> > that targets FPGAs. LiteSDCard is a small footprint, configurable
> > SDCard core commonly used in LiteX designs.
> >
> > The driver was first written in May 2020 and has been maintained
> > cooperatively by the LiteX community. Thanks to all contributors!
> 
> ...
> 
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * LiteX LiteSDCard driver
> > + *
> > + * Copyright (C) 2019-2020 Antmicro <contact@...micro.com>
> > + * Copyright (C) 2019-2020 Kamil Rakoczy <krakoczy@...micro.com>
> > + * Copyright (C) 2019-2020 Maciej Dudek <mdudek@...ernships.antmicro.com>
> > + * Copyright (C) 2020 Paul Mackerras <paulus@...abs.org>
> > + * Copyright (C) 2020-2021 Gabriel Somlo <gsomlo@...il.com>
> 
> > + *
> 
> I guess I have commented on this and there was no discussion about the
> necessity of this blank line. I dunno what else has been ignored, so I
> will wait either for the continuation of the discussion (as per v6) or
> amending code in v8.

Yeah, not sure how that got lost, it "should have" been in v7 already,
but will definitely be in v8... :)
 
BTW, I also added the `bit.h` include per your explanation, and removed
all the `Cc:` lines from the commit blurb (not sure when it's actually
appropriate to put those in vs. just cc-ing people from `git send-email`,
but I have no strong feelings about it of my own :)

> > + */
> 
> ...
> 
> On top of that it might still be the ordering issues in the error path
> of ->probe() and in ->remove(). I believe we will likely see v8.

I'll need to follow your bread crumbs on ordering and `of_match_table`
(also in some of the other emails you've sent in this thread),
and will send out v8 once I've made some sense of it all...

Thanks much,
--Gabriel