linux-kernel - Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdivZYknD2IQ1Wzy@errol.ini.cmu.edu>
Date:   Fri, 7 Jan 2022 16:23:49 -0500
From:   "Gabriel L. Somlo" <gsomlo@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        Karol Gugala <kgugala@...micro.com>,
        Mateusz Holenko <mholenko@...micro.com>,
        Kamil Rakoczy <krakoczy@...micro.com>,
        mdudek@...ernships.antmicro.com,
        Paul Mackerras <paulus@...abs.org>,
        Joel Stanley <joel@....id.au>,
        Stafford Horne <shorne@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        david.abdurachmanov@...ive.com,
        Florent Kermarrec <florent@...oy-digital.fr>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 3/3] mmc: Add driver for LiteX's LiteSDCard interface

On Fri, Jan 07, 2022 at 10:50:02PM +0200, Andy Shevchenko wrote:
> > > +             .of_match_table = of_match_ptr(litex_match),
> >
> > You said "Wrong usage of of_match_ptr()" here, and all I have to go by
> > is a bunch of other `drivers/mmc/host/*.c` files that use it in a
> > similar way, so can you please clarify and/or provide an example of how
> > to do it properly?
> 
> First of all, you have a dependency to OF, try to remove it and
> compile with OF=n and you will immediately see the issue. You may also
> go for  `git log --no-merges --grep of_match_ptr` and analyze the
> result.

Ah, grepping for "of_match_ptr" was *never* going to show me the
"right way of using of_match_ptr()" :)

OTOH, grepping for "of_match_table" (and of course the commits
returned by your command line) suggests that I simply should *not*
use it at all, and assign its argument directly to .of_match_table.

Got it, fixed it, thanks!

Now, on to the probe ordering issue... :)

Thanks,
--G