linux-kernel - Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9011348fd53b35857afb6a65f5d3163adec9a923.camel@perches.com>
Date:   Sun, 09 Jan 2022 11:01:52 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jacopo Mondi <jacopo@...ndi.org>,
        Krzysztof Hałasa <khalasa@...p.pl>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Sakari Ailus <sakari.ailus@....fi>
Subject: Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor

On Sun, 2022-01-09 at 16:34 +0100, Jacopo Mondi wrote:
> Hi Krzysztof

Hi Jacopo

Can you please trim your replies to just the sections that
you are commenting on?

Finding the reply in the duplicated reply content isn't easy.

> > +	// access the sensor only if it's powered up
> > +	if (!pm_runtime_get_if_in_use(&sensor->i2c_client->dev))
> 
> As you correctly do not access the chip's registers if it's powered
> off, you have to call __v4l2_ctrl_handler_setup() at power on time to
> make sure controls are actually set.

It was 25 pages down in the reply to find this.