linux-kernel - Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number with macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_6DDF530ADA4A09B6D49B4E0A8CD9F23D7809@qq.com>
Date:   Mon, 10 Jan 2022 22:42:02 +0800
From:   Conley Lee <conleylee@...mail.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     davem@...emloft.net, kuba@...nel.org, mripard@...nel.org,
        wens@...e.org, clabbe.montjoie@...il.com, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number with
 macro

On 01/10/22 at 03:05下午, Leon Romanovsky wrote:
> Date: Mon, 10 Jan 2022 15:05:20 +0200
> From: Leon Romanovsky <leon@...nel.org>
> To: Conley Lee <conleylee@...mail.com>
> Cc: davem@...emloft.net, kuba@...nel.org, mripard@...nel.org,
>  wens@...e.org, clabbe.montjoie@...il.com, netdev@...r.kernel.org,
>  linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v2] net: ethernet: sun4i-emac: replace magic number
>  with macro
> 
> On Mon, Jan 10, 2022 at 07:35:49PM +0800, Conley Lee wrote:
> > This patch remove magic numbers in sun4i-emac.c and replace with macros
> > defined in sun4i-emac.h
> > 
> > Change since v1
> > ---------------
> > - reformat
> > - merge commits
> > - add commit message
> 
> This changelog should be placed after "---" below your SOB.
> 
> Thanks
> 
> > 
> > Signed-off-by: Conley Lee <conleylee@...mail.com>
> > ---
> >  drivers/net/ethernet/allwinner/sun4i-emac.c | 30 ++++++++++++---------
> >  drivers/net/ethernet/allwinner/sun4i-emac.h | 18 +++++++++++++
> >  2 files changed, 35 insertions(+), 13 deletions(-)
I will reformat it and submit again, thanks ~