linux-kernel - Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57513f5f-1e66-3758-a56b-1eced486a4df@linux.microsoft.com>
Date:   Mon, 10 Jan 2022 15:12:49 -0800
From:   Dhananjay Phadke <dphadke@...ux.microsoft.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <p.yadav@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: spi-nor: Add support for w25q512jvm

On 1/10/2022 7:10 AM, Michael Walle wrote:
>
>> +    { "w25q512jvm", INFO(0xef7020, 0, 64 * 1024, 1024),
> 
> OTP_INFO(256, 3, 0x1000, 0x1000)
> 
> should enable OTP support, could you please test this using the 
> flash_otp_{dump,info,erase,write} tools and add that line?

The board I've has HW filter between controller and NOR and doesn't seem 
to allow security reg access opcodes (read to be specific).

So long as adding this doesn't affect probe, I can add it. Otherwise, 
will have to leave it for later when that's fixed.


On 1/9/2022 9:07 PM, Pratyush Yadav wrote:
>
> You need to show the dumps of the SFDP and other flash parameters. See
> [0] for an example.
>
> The patch looks fine to me otherwise.
>

Lemme collect SFDP dump and include it in v2.
I ended up sending stale patch that has extra comma between INFO() 
PARSE_SFDP macros, so need to re-spin anyway.

Thanks,
Dhananjay