linux-kernel - Re: [PATCH v4 05/48] perf stat: Switch to cpu version of cpu_map_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F6E1C874-F64D-4563-915B-F6420F987264@gmail.com>
Date:   Tue, 11 Jan 2022 15:50:07 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
To:     Ian Rogers <irogers@...gle.com>, John Garry <john.garry@...wei.com>
CC:     Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Kajol Jain <kjain@...ux.ibm.com>,
        "Paul A . Clarke" <pc@...ibm.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Riccardo Mancini <rickyman7@...il.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Vineet Singh <vineet.singh@...el.com>,
        James Clark <james.clark@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>, coresight@...ts.linaro.org,
        linux-arm-kernel@...ts.infradead.org, zhengjun.xing@...el.com,
        eranian@...gle.com
Subject: Re: [PATCH v4 05/48] perf stat: Switch to cpu version of cpu_map__get



On January 11, 2022 3:46:41 PM GMT-03:00, Ian Rogers <irogers@...gle.com> wrote:
>On Mon, Jan 10, 2022 at 11:04 AM John Garry <john.garry@...wei.com> wrote:
>>
>> On 05/01/2022 06:13, Ian Rogers wrote:
>> > Avoid bugs where the wrong index is passed with the cpu_map.
>>
>> nit: Don't you mean possible bugs?
>
>You are right. I'll watch myself doing this in the future.

I'll update the comment,

I'm still testing it and giving more time for review, including to the adjustments I made..

- Arnaldo

>
>Thanks,
>Ian
>
>> >
>> > Reviewed-by: James Clark <james.clark@....com>
>> > Signed-off-by: Ian Rogers <irogers@...gle.com>