linux-kernel - Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3fb108bc-08c5-032c-bbe1-c819e85a91ed@redhat.com>
Date:   Tue, 11 Jan 2022 10:18:31 +0100
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Kevin Tang <kevin3.tang@...il.com>,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        sean@...rly.run, airlied@...ux.ie, daniel@...ll.ch,
        robh+dt@...nel.org, mark.rutland@....com
Cc:     devicetree@...r.kernel.org, zhang.lyra@...il.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        lukas.bulwahn@...il.com, orsonzhai@...il.com, zou_wei@...wei.com,
        pony1.wu@...il.com, dan.carpenter@...cle.com
Subject: Re: [PATCH v1 2/2] drm/sprd: fix potential NULL dereference

On 12/24/21 15:12, Kevin Tang wrote:
> platform_get_resource() may fail and return NULL, so check it's value
> before using it.
> 
> 'drm' could be null in sprd_drm_shutdown, and drm_warn maybe dereference
> it, remove this warning log.
>

I would split this second change in a separate patch and just keep this
one about checking the platform_get_resource() return value.

If you do that, feel free to add:

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat