linux-kernel - Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4fa36c87-7771-28bb-15b3-82b2cb249607@suse.de>
Date:   Tue, 11 Jan 2022 10:20:32 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Kevin Tang <kevin3.tang@...il.com>,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        sean@...rly.run, airlied@...ux.ie, daniel@...ll.ch,
        robh+dt@...nel.org, mark.rutland@....com
Cc:     devicetree@...r.kernel.org, zhang.lyra@...il.com,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        lukas.bulwahn@...il.com, orsonzhai@...il.com, zou_wei@...wei.com,
        pony1.wu@...il.com, dan.carpenter@...cle.com
Subject: Re: [PATCH v1 1/2] drm/sprd: remove the selected DRM_KMS_CMA_HELPER
 in kconfig

Hi

Am 24.12.21 um 15:12 schrieb Kevin Tang:
> On linux-next, commit 43531edd53f0 ("drm/sprd: add Unisoc's drm kms master") adds the config DRM_SPRD,
> which selects DRM_KMS_CMA_HELPER.
> 
> However, commit 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") just removed the
> DRM_KMS_CMA_HELPER. So, the select DRM_KMS_CMA_HELPER refers to a non-existing kconfig symbol.

With the long lines fixed, you can add

Acked-by: Thomas Zimmermann <tzimmermann@...e.de>

Selecting DRM_GEM_CMA_HELPER and DRM_KMS_HELPER at the same time acts 
like DRM_KMS_CMA_HELPER did before.

Best regards
Thomas

> 
> Cc: Orson Zhai <orsonzhai@...il.com>
> Cc: Chunyan Zhang <zhang.lyra@...il.com>
> Signed-off-by: Kevin Tang <kevin.tang@...soc.com>
> ---
>   drivers/gpu/drm/sprd/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/sprd/Kconfig b/drivers/gpu/drm/sprd/Kconfig
> index 3edeaeca0..9a9c7ebfc 100644
> --- a/drivers/gpu/drm/sprd/Kconfig
> +++ b/drivers/gpu/drm/sprd/Kconfig
> @@ -3,7 +3,6 @@ config DRM_SPRD
>   	depends on ARCH_SPRD || COMPILE_TEST
>   	depends on DRM && OF
>   	select DRM_GEM_CMA_HELPER
> -	select DRM_KMS_CMA_HELPER
>   	select DRM_KMS_HELPER
>   	select DRM_MIPI_DSI
>   	select VIDEOMODE_HELPERS

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (841 bytes)