linux-kernel - Re: [PATCH v2] selftests: rtc: Increase test timeout so that all tests run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f286a86d-6371-d8bd-6ca9-5f622468d1a4@linuxfoundation.org>
Date:   Wed, 12 Jan 2022 16:51:12 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     Shuah Khan <shuah@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...labora.com,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: rtc: Increase test timeout so that all
 tests run

On 1/12/22 1:22 PM, Alexandre Belloni wrote:
> On 12/01/2022 14:41:42-0500, Nícolas F. R. A. Prado wrote:
>> The timeout setting for the rtc kselftest is currently 90 seconds. This
>> setting is used by the kselftest runner to stop running a test if it
>> takes longer than the assigned value.
>>
>> However, two of the test cases inside rtc set alarms. These alarms are
>> set to the next beginning of the minute, so each of these test cases may
>> take up to, in the worst case, 60 seconds.
>>
>> In order to allow for all test cases in rtc to run, even in the worst
>> case, when using the kselftest runner, the timeout value should be
>> increased to at least 120. Set it to 180, so there's some additional
>> slack.
>>
>> Correct operation can be tested by running the following command right
>> after the start of a minute (low second count), and checking that all
>> test cases run:
>>
>> 	./run_kselftest.sh -c rtc
>>
>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> Acked-by: Alexandre Belloni <alexandre.belloni@...tlin.com>

Thank you both. Will apply this for 5.17-rc2 once the merge window
closes.

thanks,
-- Shuah