linux-kernel - Re: [PATCH v2 1/1] ucsi_ccg: Check DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 12 Jan 2022 03:19:51 +0000
From:   Wayne Chang <waynec@...dia.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Sing-Han Chen <singhanc@...dia.com>
Subject: Re: [PATCH v2 1/1] ucsi_ccg: Check DEV_INT bit only when starting
 CCG4



On 1/11/22 10:25 PM, Greg KH wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Jan 11, 2022 at 02:15:17PM +0000, Wayne Chang wrote:
>> Hi Greg,
>> Thanks for the review.
>>
>> On 1/11/22 10:03 PM, Greg KH wrote:
>>>
>>>
>>> On Tue, Jan 11, 2022 at 09:36:43PM +0800, Wayne Chang wrote:
>>>> From: Sing-Han Chen <singhanc@...dia.com>
>>>>
>>>> after driver sending the UCSI_START cmd, CCGx would
>>>> clear Bit 0:Device Interrupt in the INTR_REG if CCGX
>>>> reset successfully.
>>>>
>>>> however, there might be a chance that other bits in
>>>> INTR_REG are not cleared due to internal data queued
>>>> in PPM and cause the driver thinks CCGx reset failed.
>>>>
>>>> the commit checks bit 0 in INTR_REG and ignore other
>>>> bits. ucsi driver would reset PPM later.
>>>>
>>>> Signed-off-by: Sing-Han Chen <singhanc@...dia.com>
>>>> Signed-off-by: Wayne Chang <waynec@...dia.com>
>>>> ---
>>>>    drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> What commit id does this fix?
>> The change is to fix the defect of ucsi_ccg_init func based on the CCGx
>> spec.
>> The original implementation's commit Id is i247c554a14aa1.
> 
> Great, can you resend this with a proper "Fixes:" tag on it?
Sure. Will do. Thanks for the review.
> 
> thanks,
> 
> greg k-h
> 

thanks,
Wayne.