lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Jan 2022 11:21:00 +0800 From: Wayne Chang <waynec@...dia.com> To: <heikki.krogerus@...ux.intel.com>, <gregkh@...uxfoundation.org> CC: <linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>, <singhanc@...dia.com>, <waynec@...dia.com> Subject: [PATCH v3 1/1] ucsi_ccg: Check DEV_INT bit only when starting CCG4 From: Sing-Han Chen <singhanc@...dia.com> after driver sending the UCSI_START cmd, CCGx would clear Bit 0:Device Interrupt in the INTR_REG if CCGX reset successfully. however, there might be a chance that other bits in INTR_REG are not cleared due to internal data queued in PPM and cause the driver thinks CCGx reset failed. the commit checks bit 0 in INTR_REG and ignore other bits. ucsi driver would reset PPM later. Fixes: 247c554a14aa16ca ("usb: typec: ucsi: add support for Cypress CCGx") Signed-off-by: Sing-Han Chen <singhanc@...dia.com> Signed-off-by: Wayne Chang <waynec@...dia.com> --- drivers/usb/typec/ucsi/ucsi_ccg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index bff96d64dddf..6db7c8ddd51c 100644 --- a/drivers/usb/typec/ucsi/ucsi_ccg.c +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c @@ -325,7 +325,7 @@ static int ucsi_ccg_init(struct ucsi_ccg *uc) if (status < 0) return status; - if (!data) + if (!(data & DEV_INT)) return 0; status = ccg_write(uc, CCGX_RAB_INTR_REG, &data, sizeof(data)); -- 2.25.1
Powered by blists - more mailing lists