linux-kernel - Re: [PATCH] media: i2c: remove unneeded variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e5165aa9-4622-72dc-22dd-1077648d7cbf@xs4all.nl>
Date:   Wed, 12 Jan 2022 10:19:08 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     cgel.zte@...il.com, djrscally@...il.com
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Changcheng Deng <deng.changcheng@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] media: i2c: remove unneeded variable

On 12/01/2022 10:17, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
> 
> Remove unneeded variable used to store return value.

Please add the driver name in the subject prefix! Why is that so hard to
remember?

Regards,

	Hans

> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
> ---
>  drivers/media/i2c/ov5693.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 2784fcf67f3b..a55910f6283a 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	unsigned int width, height;
>  	unsigned int hblank;
>  	int exposure_max;
> -	int ret = 0;
>  
>  	crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
>  
> @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  	format->format = *fmt;
>  
>  	if (format->which == V4L2_SUBDEV_FORMAT_TRY)
> -		return ret;
> +		return 0;
>  
>  	mutex_lock(&ov5693->lock);
>  
> @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
>  				     exposure_max));
>  
>  	mutex_unlock(&ov5693->lock);
> -	return ret;
> +	return 0;
>  }
>  
>  static int ov5693_get_selection(struct v4l2_subdev *sd,