[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ad934c70-171e-61c1-2ec8-85c7a106c656@gmail.com>
Date: Fri, 14 Jan 2022 00:03:13 +0000
From: Daniel Scally <djrscally@...il.com>
To: cgel.zte@...il.com
Cc: mchehab@...nel.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org,
Changcheng Deng <deng.changcheng@....com.cn>,
Zeal Robot <zealci@....com.cn>, hverkuil@...all.nl
Subject: Re: [PATCH] media: i2c: remove unneeded variable
Hello
On 12/01/2022 09:17, cgel.zte@...il.com wrote:
> From: Changcheng Deng <deng.changcheng@....com.cn>
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@....com.cn>
Yeah good catch. With Hans' comment about the subject line addressed:
Reviewed-by: Daniel Scally <djrscally@...il.com>
> ---
> drivers/media/i2c/ov5693.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index 2784fcf67f3b..a55910f6283a 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -950,7 +950,6 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> unsigned int width, height;
> unsigned int hblank;
> int exposure_max;
> - int ret = 0;
>
> crop = __ov5693_get_pad_crop(ov5693, state, format->pad, format->which);
>
> @@ -982,7 +981,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> format->format = *fmt;
>
> if (format->which == V4L2_SUBDEV_FORMAT_TRY)
> - return ret;
> + return 0;
>
> mutex_lock(&ov5693->lock);
>
> @@ -1012,7 +1011,7 @@ static int ov5693_set_fmt(struct v4l2_subdev *sd,
> exposure_max));
>
> mutex_unlock(&ov5693->lock);
> - return ret;
> + return 0;
> }
>
> static int ov5693_get_selection(struct v4l2_subdev *sd,
>
Powered by blists - more mailing lists