linux-kernel - Re: [PATCH v3 1/2] tpm: Fix error handling in async work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c2eeee7-0d3e-8000-67ad-3054f229cbe0@linaro.org>
Date:   Wed, 12 Jan 2022 10:47:29 -0800
From:   Tadeusz Struk <tadeusz.struk@...aro.org>
To:     Jarkko Sakkinen <jarkko@...nel.org>,
        Tadeusz Struk <tstruk@...il.com>
Cc:     Jason Gunthorpe <jgg@...pe.ca>, linux-integrity@...r.kernel.org,
        stable@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] tpm: Fix error handling in async work

On 1/12/22 10:35, Jarkko Sakkinen wrote:
> These look good to me! Thank you. I'm in process of compiling a test
> kernel.

Thanks Jarkko,
You can run the new test before and after applying the change and see
how it behaves. Also just noticed a mistake in the comment, sorry but
it was quite late when I sent it.

+	/*
+	 * If ret is > 0 then tpm_dev_transmit returned the size of the
+	 * response. If ret is < 0 then tpm_dev_transmit failed and
+	 * returned a return code.
+	 */

In the above could you please replace:

s/returned a return code/returned an error code/

before applying the patch. I would appreciate that.

-- 
Thanks,
Tadeusz