linux-kernel - RE: [sailus-media-tree:master 15/16] drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e504b20307d4eaf90e5cd2e85faf7c1@intel.com>
Date:   Thu, 13 Jan 2022 03:59:24 +0000
From:   "Tu, ShawnX" <shawnx.tu@...el.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>, lkp <lkp@...el.com>
CC:     "kbuild-all@...ts.01.org" <kbuild-all@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [sailus-media-tree:master 15/16]
 drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of
 'v4l2_subdev_get_try_format' from incompatible pointer type

Hi Sakari,

Thanks for your information.
I'll update the driver later.

Thanks,
Shawn
-----Original Message-----
From: Sakari Ailus <sakari.ailus@...ux.intel.com> 
Sent: Thursday, January 13, 2022 12:04 AM
To: lkp <lkp@...el.com>
Cc: Tu, ShawnX <shawnx.tu@...el.com>; kbuild-all@...ts.01.org; linux-kernel@...r.kernel.org
Subject: Re: [sailus-media-tree:master 15/16] drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type

Hi Shawn,

On Wed, Jan 12, 2022 at 11:18:55PM +0800, kernel test robot wrote:
>    drivers/media/i2c/hi847.c: In function 'hi847_set_format':
> >> drivers/media/i2c/hi847.c:2700:49: error: passing argument 2 of 
> >> 'v4l2_subdev_get_try_format' from incompatible pointer type 
> >> [-Werror=incompatible-pointer-types]
>     2700 |                 *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format;
>          |                                                 ^~~
>          |                                                 |
>          |                                                 struct v4l2_subdev_pad_config *

There's been an API change in how the sub-device try state is stored and accessed. The patch changing the other drivers is:

<URL:https://git.linuxtv.org/sailus/media_tree.git/commit/?id=0d346d2a6f54f06f36b224fd27cd6eafe8c83be9>

Could you make similar changes to the hi847 driver? I'll then squash that patch into the current patch adding the driver.

--
Kind regards,

Sakari Ailus