linux-kernel - RE: [PATCH -next 1/2] drm/amdgpu: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM5PR12MB24690F147E97557089106414F1539@DM5PR12MB2469.namprd12.prod.outlook.com>
Date:   Thu, 13 Jan 2022 03:59:35 +0000
From:   "Chen, Guchun" <Guchun.Chen@....com>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "Pan, Xinhui" <Xinhui.Pan@....com>,
        Abaci Robot <abaci@...ux.alibaba.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>
Subject: RE: [PATCH -next 1/2] drm/amdgpu: remove unneeded semicolon

Thanks for your patch, Yang. Can you pls also fix the original indentation problem as well?

if (!adev)
-	return -EINVAL;;
+	return -EINVAL;

Regards,
Guchun

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of Yang Li
Sent: Thursday, January 13, 2022 9:22 AM
To: airlied@...ux.ie
Cc: Pan, Xinhui <Xinhui.Pan@....com>; Abaci Robot <abaci@...ux.alibaba.com>; linux-kernel@...r.kernel.org; dri-devel@...ts.freedesktop.org; Yang Li <yang.lee@...ux.alibaba.com>; amd-gfx@...ts.freedesktop.org; daniel@...ll.ch; Deucher, Alexander <Alexander.Deucher@....com>; Koenig, Christian <Christian.Koenig@....com>
Subject: [PATCH -next 1/2] drm/amdgpu: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:2725:16-17: Unneeded semicolon

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
index d4d9b9ea8bbd..7d9d99e581da 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
@@ -2722,7 +2722,7 @@ struct amdgpu_ras* amdgpu_ras_get_context(struct amdgpu_device *adev)  int amdgpu_ras_set_context(struct amdgpu_device *adev, struct amdgpu_ras* ras_con)  {
 	if (!adev)
-	return -EINVAL;;
+	return -EINVAL;
 
 	adev->psp.ras_context.ras = ras_con;
 	return 0;
--
2.20.1.7.g153144c