linux-kernel - Re: [PATCH] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220113123530.dn33ze7yvg2jlnfv@skbuf>
Date:   Thu, 13 Jan 2022 14:35:30 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Maxim Kiselev <bigunclemax@...il.com>
Cc:     fido_max@...ox.ru, Rob Herring <robh+dt@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>, devicetree@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc: dts: t104xrdb: fix phy type for FMAN 4/5

On Thu, Dec 30, 2021 at 06:11:21PM +0300, Maxim Kiselev wrote:
> T1040RDB has two RTL8211E-VB phys which requires setting
> of internal delays for correct work.
> 
> Changing the phy-connection-type property to `rgmii-id`
> will fix this issue.
> 
> Signed-off-by: Maxim Kiselev <bigunclemax@...il.com>
> Reviewed-by: Maxim Kochetkov <fido_max@...ox.ru>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>

>  arch/powerpc/boot/dts/fsl/t104xrdb.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> index 099a598c74c00..bfe1ed5be3374 100644
> --- a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> +++ b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
> @@ -139,12 +139,12 @@ pca9546@77 {
>  		fman@...000 {
>  			ethernet@...00 {
>  				phy-handle = <&phy_rgmii_0>;
> -				phy-connection-type = "rgmii";
> +				phy-connection-type = "rgmii-id";
>  			};
>  
>  			ethernet@...00 {
>  				phy-handle = <&phy_rgmii_1>;
> -				phy-connection-type = "rgmii";
> +				phy-connection-type = "rgmii-id";
>  			};
>  
>  			mdio0: mdio@...00 {
> -- 
> 2.32.0
>