[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220114064357.18562-1-linmq006@gmail.com>
Date: Fri, 14 Jan 2022 06:43:55 +0000
From: Miaoqian Lin <linmq006@...il.com>
To: Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
"Chia-Wei, Wang" <chiawei_wang@...eedtech.com>,
Jae Hyun Yoo <jae.hyun.yoo@...el.com>,
Vernon Mauery <vernon.mauery@...ux.intel.com>,
Miaoqian Lin <linmq006@...il.com>,
Dan Carpenter <dan.carpenter@...cle.com>,
Patrick Venture <venture@...gle.com>,
Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
linux-arm-kernel@...ts.infradead.org,
linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: [PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq
platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:
int irq = platform_get_irq(pdev, 0);
if (irq < 0)
return irq;
Fix the check of return value to catch errors correctly.
Fixes: 524feb799408 ("soc: add aspeed folder and misc drivers")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
drivers/soc/aspeed/aspeed-lpc-snoop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index eceeaf8dfbeb..c4a03b3a5cf8 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -167,8 +167,8 @@ static int aspeed_lpc_snoop_config_irq(struct aspeed_lpc_snoop *lpc_snoop,
int rc;
lpc_snoop->irq = platform_get_irq(pdev, 0);
- if (!lpc_snoop->irq)
- return -ENODEV;
+ if (lpc_snoop->irq < 0)
+ return lpc_snoop->irq;
rc = devm_request_irq(dev, lpc_snoop->irq,
aspeed_lpc_snoop_irq, IRQF_SHARED,
--
2.17.1
Powered by blists - more mailing lists