linux-kernel - RE: [PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK0PR06MB377975CCF8230EB9FE35EC6A91579@HK0PR06MB3779.apcprd06.prod.outlook.com>
Date:   Mon, 17 Jan 2022 00:05:48 +0000
From:   ChiaWei Wang <chiawei_wang@...eedtech.com>
To:     Miaoqian Lin <linmq006@...il.com>, Joel Stanley <joel@....id.au>,
        Andrew Jeffery <andrew@...id.au>,
        Jae Hyun Yoo <jae.hyun.yoo@...el.com>,
        Vernon Mauery <vernon.mauery@...ux.intel.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Patrick Venture <venture@...gle.com>,
        Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] soc: aspeed: Fix IRQ check in aspeed_lpc_snoop_config_irq

> From: Miaoqian Lin <linmq006@...il.com>
> Sent: Friday, January 14, 2022 2:44 PM
> 
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
> 
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
> 
> Fix the check of return value to catch errors correctly.
> 
> Fixes: 524feb799408 ("soc: add aspeed folder and misc drivers")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Chia-Wei Wang <chiawei_wang@...eedtech.com>

Thanks.