linux-kernel - Re: [PATCH] platform/surface: Reinstate platform dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Jan 2022 15:40:50 +0100
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Jarrett Schultz <jaschultz@...rosoft.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/surface: Reinstate platform dependency

On 1/15/22 15:08, Geert Uytterhoeven wrote:
> Microsoft Surface platform-specific devices are only present on
> Microsoft Surface platforms, which are currently limited to arm64 and
> x86.  Hence add a dependency on ARM64 || X86, to prevent asking the user
> about drivers for these devices when configuring a kernel for an
> architecture that does not support Microsoft Surface platforms.
> 
> Fixes: 272479928172edf0 ("platform: surface: Propagate ACPI Dependency")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Seems sensible to me.

Acked-by: Maximilian Luz <luzmaximilian@...il.com>

> ---
>   drivers/platform/surface/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/surface/Kconfig b/drivers/platform/surface/Kconfig
> index 5f0578e25f718f14..463f1ec5c14e9fa9 100644
> --- a/drivers/platform/surface/Kconfig
> +++ b/drivers/platform/surface/Kconfig
> @@ -5,6 +5,7 @@
>   
>   menuconfig SURFACE_PLATFORMS
>   	bool "Microsoft Surface Platform-Specific Device Drivers"
> +	depends on ARM64 || X86 || COMPILE_TEST
>   	default y
>   	help
>   	  Say Y here to get to see options for platform-specific device drivers