linux-kernel - [PATCH] mpage: remove ineffective __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220115144150.1195590-1-shakeelb@google.com>
Date:   Sat, 15 Jan 2022 06:41:50 -0800
From:   Shakeel Butt <shakeelb@...gle.com>
To:     Alexander Viro <viro@...iv.linux.org.uk>,
        Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Shakeel Butt <shakeelb@...gle.com>
Subject: [PATCH] mpage: remove ineffective __GFP_HIGH flag

Since the commit 8a5c743e308dd ("mm, memcg: use consistent gfp flags
during readahead") mpage_alloc is clearing all the flag bits other than
bits in GFP_KERNEL internally. Simply remove __GFP_HIGH from the call to
mpage_alloc as it is cleared by it.

Signed-off-by: Shakeel Butt <shakeelb@...gle.com>
---
 fs/mpage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index 87f5cfef6caa..477ccc3f3ac3 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -609,7 +609,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
 				goto out;
 		}
 		bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
-				BIO_MAX_VECS, GFP_NOFS|__GFP_HIGH);
+				  BIO_MAX_VECS, GFP_NOFS);
 		if (bio == NULL)
 			goto confused;
 
-- 
2.34.1.703.g22d0c6ccf7-goog