lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Jan 2022 14:24:59 +0100 From: Dominik Brodowski <linux@...inikbrodowski.net> To: "Jason A. Donenfeld" <Jason@...c4.com> Cc: linux-kernel@...r.kernel.org, tytso@....edu Subject: Re: [PATCH 5/7] random: rather than entropy_store abstraction, use global > -static void __mix_pool_bytes(struct entropy_store *r, const void *in, > - int nbytes) > +static void __mix_pool_bytes(const void *in, int nbytes) > { > - trace_mix_pool_bytes_nolock(r->name, nbytes, _RET_IP_); > - _mix_pool_bytes(r, in, nbytes); > + trace_mix_pool_bytes_nolock(nbytes, _RET_IP_); > + _mix_pool_bytes(in, nbytes); Can the parameters of these tracepoints be modified, or does this break any part of our API? I haven't looked at the tracepoint bits in detail; otherwise, the changes look good: Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net> # random.c only Thanks, Dominik
Powered by blists - more mailing lists