linux-kernel - Re: [PATCH 6/7] random: remove unused OUTPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YeQcsEB+aO/DxGts@owl.dominikbrodowski.net>
Date:   Sun, 16 Jan 2022 14:25:04 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-kernel@...r.kernel.org, tytso@....edu
Subject: Re: [PATCH 6/7] random: remove unused OUTPUT_POOL constants

Am Thu, Jan 13, 2022 at 04:44:12PM +0100 schrieb Jason A. Donenfeld:
> We no longer have an output pool. Rather, we have just a wakeup bits
> threshold for /dev/random reads, presumably so that processes don't
> hang. This value, random_write_wakeup_bits, is configurable anyway. So
> all the no longer usefully named OUTPUT_POOL constants were doing was
> setting a reasonable default for random_write_wakeup_bits. This commit
> gets rid of the constants and just puts it all in the default value of
> random_write_wakeup_bits.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

	Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net>

Thanks,
	Dominik