linux-kernel - Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYSmgziDQuMU7McW2QQ_M7S16gPb6TgzRX2UkNzt2QdaA@mail.gmail.com>
Date:   Sun, 16 Jan 2022 13:07:34 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe

On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <linmq006@...il.com> wrote:

> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij