linux-kernel - Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfN1zybtDcR882GtqkYivCE-pPUCxM9aNgs9EN8vohYNA@mail.gmail.com>
Date:   Mon, 17 Jan 2022 14:19:25 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: idt3243x: Fix IRQ check in idt_gpio_probe

On Fri, Jan 14, 2022 at 7:51 AM Miaoqian Lin <linmq006@...il.com> wrote:
>
> platform_get_irq() returns negative error number instead 0 on failure.
> And the doc of platform_get_irq() provides a usage example:
>
>     int irq = platform_get_irq(pdev, 0);
>     if (irq < 0)
>         return irq;
>
> Fix the check of return value to catch errors correctly.
>
> Fixes: 4195926aedca ("gpio: Add support for IDT 79RC3243x GPIO controller")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
>  drivers/gpio/gpio-idt3243x.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-idt3243x.c b/drivers/gpio/gpio-idt3243x.c
> index 50003ad2e589..08493b05be2d 100644
> --- a/drivers/gpio/gpio-idt3243x.c
> +++ b/drivers/gpio/gpio-idt3243x.c
> @@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
>                         return PTR_ERR(ctrl->pic);
>
>                 parent_irq = platform_get_irq(pdev, 0);
> -               if (!parent_irq)
> -                       return -EINVAL;
> +               if (parent_irq < 0)
> +                       return parent_irq;
>
>                 girq = &ctrl->gc.irq;
>                 girq->chip = &idt_gpio_irqchip;
> --
> 2.17.1
>

Queued for fixes, thanks!

Bart