linux-kernel - Re: [PATCH] clk: imx: Add imx8dxl clk driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YeaVL33SMFHc8pZ3@abelvesa>
Date:   Tue, 18 Jan 2022 12:23:43 +0200
From:   Abel Vesa <abel.vesa@....com>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Fabio Estevam <festevam@...il.com>,
        Mike Turquette <mturquette@...libre.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        NXP Linux Team <linux-imx@....com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jacky Bai <ping.bai@....com>
Subject: Re: [PATCH] clk: imx: Add imx8dxl clk driver

On 22-01-18 12:18:18, Abel Vesa wrote:
> On 21-12-16 10:50:23, Stephen Boyd wrote:
> > Quoting Abel Vesa (2021-11-10 09:56:40)
> > > diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
> > > index c53a688d8ccc..7f4893706cc2 100644
> > > --- a/drivers/clk/imx/clk-imx8qxp.c
> > > +++ b/drivers/clk/imx/clk-imx8qxp.c
> > > @@ -297,6 +297,7 @@ static const struct of_device_id imx8qxp_match[] = {
> > >         { .compatible = "fsl,scu-clk", },
> > >         { .compatible = "fsl,imx8qxp-clk", &imx_clk_scu_rsrc_imx8qxp, },
> > >         { .compatible = "fsl,imx8qm-clk", &imx_clk_scu_rsrc_imx8qm, },
> > > +       { .compatible = "fsl,imx8dxl-clk", &imx_clk_scu_rsrc_imx8dxl, },
> > 
> > Can you keep this sorted on compatible string? Then we don't have to
> > worry about conflicts as much.
> > 
> 
> Yep. Will resend.

Actually, v2 is right here:

https://lore.kernel.org/linux-arm-kernel/1639747533-9778-1-git-send-email-abel.vesa@nxp.com/

You ACK'ed it already. And it adds the dxl compatible in the right spot.

> 
> > >         { /* sentinel */ }
> > >  };
> > >