linux-kernel - Re: [PATCH v2 24/28] dt-bindings: pinctrl: samsung: convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <794f39ed-3436-432c-767d-8fa60779d510@canonical.com>
Date:   Tue, 18 Jan 2022 08:52:33 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Olof Johansson <olof@...om.net>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Tomasz Figa <tomasz.figa@...il.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Linux ARM Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Sam Protsenko <semen.protsenko@...aro.org>,
        Chanho Park <chanho61.park@...sung.com>,
        Alim Akhtar <alim.akhtar@...il.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 24/28] dt-bindings: pinctrl: samsung: convert to
 dtschema

On 17/01/2022 21:26, Olof Johansson wrote:
> On Sun, Jan 16, 2022 at 11:45 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@...onical.com> wrote:
>>
>> On 16/01/2022 22:38, Linus Walleij wrote:
>>> On Sun, Jan 16, 2022 at 6:10 PM Krzysztof Kozlowski
>>> <krzysztof.kozlowski@...onical.com> wrote:
>>>
>>>> Anyway DTS and dtschema will have to wait for one release, because they
>>>> depend on samsung pinctrl driver change (patch #2).
>>>
>>> What about I put that (and maybe this schema) on an immutable
>>> branch so you can pull the commit into your for-arm-soc branch and
>>> put the DTS changes on top?
>>
>> That would be a solution if not a policy for arm-soc of keeping DTS
>> separate. Arnd and Olof since some time are not happy when DTS branch
>> receives any driver updates.
>>
>> Arnd, Olof,
>> This is a set of dtschema conversion + DTS alignment with new schema:
>> 1. Driver change necessary to accept new DTS (driver depends on node
>> names and this has to change because of dtschema),
>> 2. DTS commits depending on above, which convert node name to new format,
>> 3. Finally dtschema requiring new naming of the GPIO nodes.
>>
>> If I got correctly, the policy of not mixing drivers and DTS requires
>> that #2 above (DTS changes) will wait for one more release. During the
>> time, if dtschema (#3 above) is applied, there will be new warnings
>> about non-compliant DTS.
>>
>> Do you see any chance of merging driver + DTS + dtschema via same tree
>> in same release?
> 
> Our general guidance to separate DTS and driver changes is to avoid
> large entangled changes between the two, and to discourage a developer
> mentality of "the implementation is the binding".
> 
> I think this is a good example of when it makes sense to bring in what
> is a fairly small and clean driver change to deal with this. So the
> right answer here is to stage such a stable branch and merge into both
> arm-soc and the pinctrl subsystem trees as proposed.

Thanks for clarification, I'll go with this approach.

Best regards,
Krzysztof