linux-kernel - Re: [PATCH v3] scsi: bnx2fc: flush destroy_work queue before calling bnx2fc_interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1pmool6y1.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 18 Jan 2022 22:51:03 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     John Meneghini <jmeneghi@...hat.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        GR-QLogic-Storage-Upstream@...vell.com, mlombard@...hat.com,
        skashyap@...vell.com, guazhang@...hat.com
Subject: Re: [PATCH v3] scsi: bnx2fc: flush destroy_work queue before
 calling bnx2fc_interface_put


John,

> The bnx2fc_destroy functions are removing the interface before calling
> destroy_work. This results multiple WARNings from sysfs_remove_group
> as the controller rport device attributes are removed to early.
>
> Replace the fcoe_port's destroy_work queue.  It's not needed.

Applied to 5.17/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering