linux-kernel - Re: [PATCH] usb: gadget: at91_udc: fix incorrect print type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eef429fa-d9d5-e0ea-8d19-45563fae27dc@mediatek.com>
Date:   Wed, 19 Jan 2022 11:52:43 +0800
From:   Macpaul Lin <macpaul.lin@...iatek.com>
To:     Miles Chen <miles.chen@...iatek.com>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Balamanikandan Gunasundar 
        <balamanikandan.gunasundar@...rochip.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Dan Sneddon <dan.sneddon@...rochip.com>
CC:     <linux-usb@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH] usb: gadget: at91_udc: fix incorrect print type

On 1/19/22 10:08 AM, Miles Chen wrote:
> Fix a build error observed with ARCH=arm DEFCONFIG=allmodconfig build.
> 
> drivers/usb/gadget/udc/at91_udc.h:174:42: error: format '%d' expects argument of type 'int', but argument 3 has type 'struct gpio_desc *' [-Werror=format=]
> 
> Fixes: 4a555f2b8d31 ("usb: gadget: at91_udc: Convert to GPIO descriptors")
> Signed-off-by: Miles Chen <miles.chen@...iatek.com>
> ---
>   drivers/usb/gadget/udc/at91_udc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/udc/at91_udc.c b/drivers/usb/gadget/udc/at91_udc.c
> index dd0819df096e..9040a0561466 100644
> --- a/drivers/usb/gadget/udc/at91_udc.c
> +++ b/drivers/usb/gadget/udc/at91_udc.c
> @@ -1895,7 +1895,7 @@ static int at91udc_probe(struct platform_device *pdev)
>   					at91_vbus_irq, 0, driver_name, udc);
>   			if (retval) {
>   				DBG("request vbus irq %d failed\n",
> -				    udc->board.vbus_pin);
> +				    desc_to_gpio(udc->board.vbus_pin));
>   				goto err_unprepare_iclk;
>   			}
>   		}
> 

Reviewed-by: Macpaul Lin <macpaul.lin@...iatek.com>

Thanks!
Macpaul Lin