linux-kernel - Re: [PATCH 5.16 00/28] 5.16.2-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+G9fYvJaFVKu24oFuR1wGFRe4N2A=yxH6ksx61bunfR9Y3Ejw@mail.gmail.com>
Date:   Wed, 19 Jan 2022 13:00:33 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Christian Brauner <christian.brauner@...ntu.com>,
        NeilBrown <neilb@...e.de>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, linux@...ck-us.net, shuah@...nel.org,
        patches@...nelci.org, lkft-triage@...ts.linaro.org, pavel@...x.de,
        jonathanh@...dia.com, f.fainelli@...il.com, stable@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 5.16 00/28] 5.16.2-rc1 review

On Tue, 18 Jan 2022 at 21:41, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.16.2 release.
> There are 28 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Jan 2022 16:04:42 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.2-rc1.gz
> or in the git tree and branch at:
>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Following patch caused build regression for powerpc allnoconfig only on 5.16
with gcc-9.

5.16-powerpc-gcc-9-allnoconfig   - FAIL
5.16-powerpc-gcc-10-allnoconfig  - PASS
5.16-powerpc-gcc-11-allnoconfig  - PASS


make --silent --keep-going --jobs=8 \
  O=/home/tuxbuild/.cache/tuxmake/builds/current \
  ARCH=powerpc \
  CROSS_COMPILE=powerpc64le-linux-gnu- \
 'CC=sccache powerpc64le-linux-gnu-gcc' \
  'HOSTCC=sccache gcc'

Inconsistent kallsyms data
Try make KALLSYMS_EXTRA_PASS=1 as a workaround
make[1]: *** [/builds/linux/Makefile:1161: vmlinux] Error 1
make[1]: *** Deleting file 'vmlinux'

> NeilBrown <neilb@...e.de>
>     devtmpfs regression fix: reconfigure on each mount

Bisect log:
# bad: [979dd812ffb543a3f6218868a26a701054ba3b8c] Linux 5.16.2-rc1
# good: [80820ae87cc8c09b828faa951f44b2396a5b48c4] drm/i915: Avoid
bitwise vs logical OR warning in snb_wm_latency_quirk()
git bisect start '979dd812ffb543a3f6218868a26a701054ba3b8c'
'80820ae87cc8c09b828faa951f44b2396a5b48c4'
# bad: [6cb89b83384df47b2def88870be10db707a77649] 9p: only copy valid
iattrs in 9P2000.L setattr implementation
git bisect bad 6cb89b83384df47b2def88870be10db707a77649
# bad: [041b83007bd86ba0e7275e348eb13df13df669ef] vfs: fs_context: fix
up param length parsing in legacy_parse_param
git bisect bad 041b83007bd86ba0e7275e348eb13df13df669ef
# bad: [a7458144427accc2b602a672b1f9435e00ba578e] devtmpfs regression
fix: reconfigure on each mount
git bisect bad a7458144427accc2b602a672b1f9435e00ba578e
# good: [5c245afa643712977fd0a9c70ffbb9df5dbf204b] parisc: Fix
pdc_toc_pim_11 and pdc_toc_pim_20 definitions
git bisect good 5c245afa643712977fd0a9c70ffbb9df5dbf204b
# good: [677615cd2689a0898dd58e51d12abe6663567b24] Linux 5.16.1
git bisect good 677615cd2689a0898dd58e51d12abe6663567b24
# first bad commit: [a7458144427accc2b602a672b1f9435e00ba578e]
devtmpfs regression fix: reconfigure on each mount
The first bad commit:
commit a7458144427accc2b602a672b1f9435e00ba578e
Author: NeilBrown <neilb@...e.de>
Date:   Mon Jan 17 09:07:26 2022 +1100
    devtmpfs regression fix: reconfigure on each mount

    commit a6097180d884ddab769fb25588ea8598589c218c upstream.

    Prior to Linux v5.4 devtmpfs used mount_single() which treats the given
    mount options as "remount" options, so it updates the configuration of
    the single super_block on each mount.

    Since that was changed, the mount options used for devtmpfs are ignored.
    This is a regression which affect systemd - which mounts devtmpfs with
    "-o mode=755,size=4m,nr_inodes=1m".

    This patch restores the "remount" effect by calling reconfigure_single()

    Fixes: d401727ea0d7 ("devtmpfs: don't mix
{ramfs,shmem}_fill_super() with mount_single()")
    Acked-by: Christian Brauner <christian.brauner@...ntu.com>
    Cc: Al Viro <viro@...iv.linux.org.uk>
    Signed-off-by: NeilBrown <neilb@...e.de>
    Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
 drivers/base/devtmpfs.c    | 7 +++++++
 fs/super.c                 | 4 ++--
 include/linux/fs_context.h | 2 ++
 3 files changed, 11 insertions(+), 2 deletions(-)

you may compare build results here.
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.16.y/build/v5.16-67-g979dd812ffb5/testrun/7410428/suite/build/test/gcc-9-allnoconfig/history/

Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>

--
Linaro LKFT
https://lkft.linaro.org